Add Object.getOwnPropertyNames tests #368
Conversation
|
Some of the problems show here, but are they fixable, I don't know/not sure yet? |
Xotic750
changed the title
tests/spec/s-object.js
Outdated
| }); | ||
|
|
||
| itHasUint8Array('works on Uint8Array', function () { | ||
| expect(Object.getOwnPropertyNames(new Uint8Array(4))).toEqual(['0', '1', '2', '3']); |
There was a problem hiding this comment.
typed array, arraybuffer, and dataview tests don't belong in es6-shim right now, since it doesn't address either one.
There was a problem hiding this comment.
Ok, I have a couple of other tests to add to this, but I'm not necessarily expecting any fixes. All of these, in this first push, I am already dealing with in app, but if any fixes come of them then it will be great. One of the problems that shows with es6-shim loaded is constructor shows up on Map and Set. I'll add the rest soon. My fork of es6-shim works on Travis without having to PR and I can just link to the results so that you can see.
There was a problem hiding this comment.
That'd be a Map and Set test, not a getOwnPropertyNames test :-) thanks for reporting that, I'll see if I can fix it.
Xotic750
force-pushed
the
getOwnPropertyNames
branch
6 times, most recently
from
42d8b4c to
ce8db2e
Compare
|
This shows the majority of differences that I am seeing with just es5-shim loaded, and then there are others that I see with es6-shim also loaded. Feel free to comment as usual, there's always room for improvement. ;) |
|
Since this is the es5-shim, no code dealing with ES6 constructs, like Typed Arrays, Maps, Sets, DataViews, etc, belongs in this repo. Please file es6-shim issues (including ES5 features interacting with ES6 features) on es6-shim, and I'll be happy to fix them. |
|
For all these test cases, can you include a comment indicating where it fails? |
|
I'll split out tests and include some comments over the next week. I tried to exclude any tests where it is shammed, by limiting them to |
Xotic750
force-pushed
the
getOwnPropertyNames
branch
from
ce8db2e to
50a697f
Compare
Xotic750
force-pushed
the
getOwnPropertyNames
branch
from
50a697f to
e947aed
Compare
|
@Xotic750 can you check the "allow edits" box on the RHS of the PR? it'd also be great if you wanted to rebase this so we can get it in :-) |
|
ping @Xotic750 |
I'm experiencing some issues since loading
es6-shimon my projects, I believe the issue is withObject.getOwnPropertyNamesbut I'm not sure if it is an ES5 or an ES6 issue yet, or maybe both. I'm still unable to get my fork building on Travis CI and need to PR it to begin figuring things out. It maybe that this ends up being closed here and opened over in es6-shim.